tarantool / graphql

GraphQL implementation in Lua
MIT License
15 stars 3 forks source link

Fix rockspec and version injection #53

Closed Totktonada closed 2 years ago

Totktonada commented 2 years ago

This patchset should actually finish the implementatoin of the graphql.VERSION string generation.

Follows up #29.

Totktonada commented 2 years ago

There are several alternatives:

The unobvious thing about first two options is that they only work while tarantoolctl rocks make/pack is invoked from inside the git repository (see https://github.com/tarantool/graphql/pull/50#issuecomment-1086989280). Burrying it down to the tarantoolctl rocks make/pack level just hides what is actually going on.

So I prefer the simple and explicit variant and propose it here.