tarantool / graphql

GraphQL implementation in Lua
MIT License
15 stars 3 forks source link

Describe query AST #6

Closed Totktonada closed 2 years ago

Totktonada commented 4 years ago

Source: https://github.com/tarantool/graphql.0/commit/87bb0c8d602c88b2e38b316c95a7dba78b1ec6ae

Totktonada commented 3 years ago

@RunsFor Hi! Please, excuse me for the delay too. And thank you for the in-depth review!

I rebased the patch at top of current master and fixed all comments except ones about providing examples. I'll return there when time permits. I'll mark the PR as draft until I'll resolve all comments.

Totktonada commented 3 years ago

Updated with two changes.

no1seman commented 2 years ago

@Totktonada Is this the same: https://github.com/tarantool/graphqlapi/blob/master/docs/types.md?

Totktonada commented 2 years ago

It is query AST.

Totktonada commented 2 years ago

@RunsFor Are you interested to look into the pull request again?

Totktonada commented 2 years ago

@olegrok What do you think on this? I would like to proceed in either way: drop at all, push first patch or push both patches.

olegrok commented 2 years ago

@olegrok What do you think on this? I would like to proceed in either way: drop at all, push first patch or push both patches.

I like both patches. However currently I think it's better to place them to luagraphqlparser repo

Totktonada commented 2 years ago

I like both patches. However currently I think it's better to place them to luagraphqlparser repo

Seems meaningful. I'll close this pull request and will open another one in graphqlparser if time will permit.