search

tarantool / mkrepo

Maintain DEB and RPM repositories on S3
70 stars 24 forks source link

Flake8 improvements #39

Closed VitaliyaIoffe closed 2 years ago

VitaliyaIoffe commented 3 years ago

This is my suggestion about using flake8. Currently mkrepo contains a small group of problematic errors, so, I'd like to fix it and set the flake8 as a mandatory workflow. All changes are discussable, please, write your preferences in a code style.

knazarov commented 2 years ago

In addition to flake8, it may also make sense to add black to auto-format code. It's a good auto-formatter that I had a pleasure to deal with.

PS: not necessarily in the context of this patch.

knazarov commented 2 years ago

Is this ready to be merged?

VitaliyaIoffe commented 2 years ago

Is this ready to be merged?

No, still in progress.