search

tarantool / mkrepo

Maintain DEB and RPM repositories on S3
69 stars 24 forks source link

Fix parsing signed dsc files #61

Closed ylobankov closed 2 years ago

ylobankov commented 2 years ago

Sometimes .dsc files can be signed and mkrepo didn't handle such cases. Now it is fixed. Also, added a test for parsing a signed .dsc file.

Part of #58

ylobankov commented 2 years ago

Hi! Thank you for the patch. If it works fine - LGTM. Several nits:

  • we usually include the test in the commit with the fix / feature. Up to you.
  • test: add one test for debrepo.py the title says nothing. i think test: add check parsing signed dsc file will be better and it Follows up #58.
  • right now, the signature information is just skipped, i.e. no support for parsing signed dsc has been added. I will be fine with either of two options: push commits as Part of #... or push them as Fixes #..., but with creating a task to support parsing signed dsc.

Thank you for review, fixed.

Totktonada commented 2 years ago

Asked @knazarov for feedback.

Totktonada commented 2 years ago

Kostya approved it.