search

tarantool / queue

Create task queues, add and take jobs, monitor failed tasks
Other
234 stars 52 forks source link

abstract: fix switch in_replicaset value #186

Closed oleg-jukovec closed 1 year ago

oleg-jukovec commented 1 year ago

Execution of non-yielding DDL statements in transactions has been allowed only since Tarantool 2.2.1 [1]. We should avoid using DDL statements in transactions for older versions.

  1. https://github.com/tarantool/tarantool/commit/f266559b167b4643c377724eebde9651877d6cc9

Closes #185

This patchset includes a few fixes, mostly typos. So I recommend to review commits one by one. I can extract it into a separate pull request, if you wish, but the fixes are really small.

oleg-jukovec commented 1 year ago

About commit messages:

  • "abstract: error if failed to create a temp tube" -> "abstract: throw an error if failed to create a temp tube"
  • "The create_table method returns" -> "The create_tube method returns"
  • "fix: switch in_replicaset value with tnt < 2.2.1" - "fix" not is a subsystem.

Thank you, I've tried to do the best:

https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message