search

tarantool / queue

Create task queues, add and take jobs, monitor failed tasks
Other
237 stars 52 forks source link

avoid unneeded :transform in tube.delete #70

Closed aleclarson closed 4 years ago

aleclarson commented 6 years ago

All the queue drivers do :transform(2, 1, state.DONE) before returning the task from their .delete method.

bigbes commented 6 years ago

This is needed to notify the user that task is successfully done. Why is it bothering you?

aleclarson commented 6 years ago

@bigbes The queue drivers already do that in their delete methods.

https://github.com/tarantool/queue/blob/593c9f6f949c84865bcd383d542876ebbc93520a/queue/abstract/driver/fifo.lua#L80

https://github.com/tarantool/queue/blob/593c9f6f949c84865bcd383d542876ebbc93520a/queue/abstract/driver/fifottl.lua#L296

https://github.com/tarantool/queue/blob/593c9f6f949c84865bcd383d542876ebbc93520a/queue/abstract/driver/utube.lua#L95

https://github.com/tarantool/queue/blob/593c9f6f949c84865bcd383d542876ebbc93520a/queue/abstract/driver/utubettl.lua#L309

LeonidVas commented 4 years ago

LGTM

LeonidVas commented 4 years ago

Continue https://github.com/tarantool/queue/pull/118

Totktonada commented 4 years ago

Closed in favor of #118.