search

tarantool / queue

Create task queues, add and take jobs, monitor failed tasks
Other
237 stars 52 forks source link

utubettl: remove unnecessary on_task_change call #97

Closed iskandarov-egor closed 4 years ago

iskandarov-egor commented 4 years ago

It seems it is possible that a next task of utube may be taken before the previous one is acked. It violates guarantees of strict odrdering within a utube.

How? Does my patch introduce this bug, or does it already exist?

LeonidVas commented 4 years ago

I had a conversation with @Totktonada and your code is generally ok. Now it needs to be decorated in accordance with the general points https://github.com/tarantool/tarantool/wiki/Code-review-procedure (commit message, comments, tests if possible). You can do this work yourself or forward it to us. Which pill do you choose?

artur-barsegyan commented 4 years ago

I had a conversation with @Totktonada and your code is generally ok. Now it needs to be decorated in accordance with the general points https://github.com/tarantool/tarantool/wiki/Code-review-procedure (commit message, comments, tests if possible). You can do this work yourself or forward it to us. Which pill do you choose?

I think we should make an optimistic merge in the future :)

Totktonada commented 4 years ago

I think we should make an optimistic merge in the future :)

Only sceptics can keep quality on the production level. Sometimes you're lucky and 'rapid development' approach seems to work, but it does not scale to a time period like several years. There are ways to exploit this rule: say, hire a large QA team and perform thorough pre-release testing. But it is costly.

It is based on my experience, which is not a gold standard. Maybe your experience in long living projects is different.

LeonidVas commented 4 years ago

Has been updated and pushed to master.