Add support to update options on release (RFC)

tarantool / sharded-queue

Sharded queue

12 stars 5 forks source link

Open pnvasanth opened 3 years ago

pnvasanth commented 3 years ago

Currently we are not supporting the options update on release.

Which is available in Tarantool Queue.

Can we please add the support?

akudiyar commented 3 years ago

fifottl driver in tarantool/queue supports the delay parameter: https://github.com/tarantool/queue/blob/8a8818f387d09eb2ce0d6e455576920681ae3ddf/queue/abstract/driver/fifottl.lua#L298 I think adding the same option is a good idea. The implementation may also be borrowed from there.

pnvasanth commented 3 years ago

@akudiyar it's sounds good to me.

rybakit commented 3 years ago

Also, please consider updating other options besides ttl and delay, see https://github.com/tarantool/queue/issues/125.

akudiyar commented 3 years ago

@pnvasanth Feel free to make a PR with these changes, we'll check and accept it.

pnvasanth commented 3 years ago

@akudiyar Sure, We need to fix #44 to support options. I will create a PR for both.