Receiving trash from persistent connect when there was timeout before

[deadbabe]

When getting read timeout on persistent connect, socket is still alive and well and able to receive data.

This leads to getting trash from such connect on next request, or even receiving fully valid response, just not for the latest request, but for previous one.

This 06845559 kinda helps, but for complete safety it's might be better to reconnect on every uncertainty with connection - #112

Another workaround would be to mark timeout'd connects with a "dirty" flag and read out its buffer completely later, before next request or on php request shutdown.

[bigbes]

Hello @deadbabe . Thank you for your bug report. I can reproduce this bug with tarantool-3.ini suite (that'll test timeout case with persistent connection).

What had happened: 1) opened persistent stream 2) make persistent read (that'll block until timeout had happened) 3) make php_stream_free(stream, PHP_STREAM_FREE_CLOSE_PERSISTENT)/php_stream_pclose(stream) 4) open new stream with the same persistent id 5) get still opened previous fd

I can't catch this bug under gdb:

• php_sockop_close isn't called
• if i'll put breakpoint to tntll_stream_close - everything works fine (it's a kind of magic)

This issues needs further investigation. As a workaround you can provide alternative persistent_id for new connection.

[Totktonada]

Note (for myself): suffix/suffix_len are not stored in struct tarantool_connection, but used in __tarantool_connect() and tarantool_connection_free(). Mistake? Consider the following patch:

diff --git a/src/tarantool.c b/src/tarantool.c
index 91a9ac2..59d9e2d 100644
--- a/src/tarantool.c
+++ b/src/tarantool.c
@@ -1077,7 +1077,7 @@ PHP_METHOD(Tarantool, __construct) {
        long   port = 0;

        zend_bool is_persistent = false, plist_new_entry = true;
-       const char *suffix = NULL;
+       char *suffix = NULL;
        size_t suffix_len = 0;
        zend_string *plist_id = NULL;

@@ -1148,6 +1148,8 @@ PHP_METHOD(Tarantool, __construct) {
                /* CHECK obj->schema */
                obj->tps = tarantool_tp_new(obj->value, is_persistent);
                /* CHECK obj->tps */
+               obj->suffix = suffix;
+               obj->suffix_len = suffix_len;
        }

        if (is_persistent && plist_new_entry) {

This, however, does not fixes the problem on tarantool-3.ini testing configuration.

[Totktonada]

NB: When the obj (struct tarantool_connection) can be non-NULL? Copying? Is it handled right?

[Totktonada]

See also https://github.com/tarantool-php/client/commit/ee6bc94db592796123f8c2541f69594fa8453c31