CI is green even when a test fails - Githubissues

tarantool / tarantool-python

Python client library for Tarantool

https://www.tarantool.io

BSD 2-Clause "Simplified" License

100 stars 48 forks source link

CI is green even when a test fails #121

Closed Totktonada closed 5 years ago

Totktonada commented 5 years ago

Now I see 'ImportError: No module named yaml' in CI, but the status of jobs green anyway. This issue is about the confusing green status.

What we need to do as I see:

Enable strict mode in test.sh (I suggest to use /bin/sh and set -exu # Strict shell (w/o -o pipefail) and no IFS replacing).
Investigate why python setup.py test returns exit code 0 after a failed test and fix.
Remove ipython in shebangs.
Make all unit tests executable (if they can be run w/o harness) or non-executable and remove shebangs.