Closed msiomkin closed 5 years ago
BTW, there is the task about distros updating (#123). I have pinged Alexander about that.
I decided to skip review ping-pong and reworked some parts of the patch where I guess I can improve things. I have made the following changes:
addrs
argument from changing: copy it before inserting host+port.cycle
usage in RoundRobinStrategy to implement self.pos adjusting properly (when a current address is in the new address list).self.connected = False
in connection.py::close(). I looked at the git history and it is intended to be the internal field. Added test case for connect() after close() in PR #144. If we want to provide the way to determine whether a connection is alive we need to expose a function. But maybe ping() should be used for this.Maybe I missed to mention something in the list.
@robinhood23rus Can you please give me feedback about the new version of the patch (force-pushed here).
Reorganized parse_uri()
to get rid of asserts and make it obvious that its conditions are always met.
Changes ok. Approve
Periodically call a user-defined Lua function on a node to obtain or refresh the full cluster nodes list.
Resolves: #134