search

tarantool / tarantool-python

Python client library for Tarantool
https://www.tarantool.io
BSD 2-Clause "Simplified" License
100 stars 48 forks source link

Make code compatible with Python3 #181

Closed ligurio closed 3 years ago

Totktonada commented 3 years ago

See CI on the master branch: python 3 is supported and verified. So I don't understand a problem you tries to solve.

Say, unittest.TestCase contains both assertRaisesRegexp() and assertRaisesRegex() on Python 3.7.6. Even if it would not, we don't need a library to make the simple alias. x.items() from Python 2 is the same as list(x.items()) in Python 3, but it does not meant that you need to follow py2to3 everywhere it suggest you to do so. Mostly it is just doesn't necessary and a view on a mapping object is what you need.

Please, pay attention to don't break Python 2 code.

If I'm too early here, I suggest to mark the PR as draft.

ligurio commented 3 years ago

See CI on the master branch: python 3 is supported and verified. So I don't understand a problem you tries to solve.

Yep, code is actually already compatible with Python 3. There are only two places required to fix: print calls and exec call. Please review these two patches. CI is green.

Please, pay attention to don't break Python 2 code.

Sure.