tarantool / tarantool-python

Python client library for Tarantool
https://www.tarantool.io
BSD 2-Clause "Simplified" License
100 stars 48 forks source link

internal: drop graceful shutdown feature flag #263

Closed DifferentialOrange closed 1 year ago

DifferentialOrange commented 1 year ago

Graceful shutdown was introduced in Tarantool with [1]. A week later it was reworked with [2]. So the timeline is as follows.

So the idea for users is "IPROTO_FEATURE_GRACEFUL_SHUTDOWN and protocol version 4 never existed". It also means that any new feature flag may have value 4 (same as IPROTO_FEATURE_GRACEFUL_SHUTDOWN), but with completely different meaning. IPROTO_FEATURE_GRACEFUL_SHUTDOWN flag was added in [3] by mistake due to misunderstanding the event timeline. This patch removes the flag. Since _features dict is an internal of a connection object, the change shouldn't break anything for users.

  1. https://github.com/tarantool/tarantool/commit/6f29f9d7725331d74d5e9a57a4922b1c3801ad50
  2. https://github.com/tarantool/tarantool/commit/2e9cbec3091e7c5d6ca1d7dad4305333e70f5876
  3. https://github.com/tarantool/tarantool-python/pull/243

Closes #262