search

tarantool / tarantool-python

Python client library for Tarantool
https://www.tarantool.io
BSD 2-Clause "Simplified" License
101 stars 46 forks source link

iproto: disable feature discovery for specific versions #284

Closed olegrok closed 1 year ago

olegrok commented 1 year ago

"IProto features" are available since Tarantool 2.10 and there is no need to even try to fetch them for lower versions. Such check there is in netbox code [1]. Before this patch cartridge remote control closed the connection after RequestProtocolVersion however but for netbox it worked fine. So let's uniform behaviour between connectors adding a small check to skip request if there is a gurarntee that "IProto features" are not supported.

Closes #283

[1] https://github.com/tarantool/tarantool/pull/6434/commits/2cbec82d8451670967252862893795dcf6371adb#diff-a47383908beda20a06c9f64bf5c3d4c51879034e38bcdccdf45210e89ce6dfb7R1947

olegrok commented 1 year ago

Can you add a changelog entry?

Yes. Fixed.

BTW, would you want a tagged release after I merge this one?

If you don't have any plans to add new features then yes. Otherwise I could wait some time.

DifferentialOrange commented 1 year ago

If you don't have any plans to add new features then yes. Otherwise I could wait some time.

It seems that there is a bug issue which could also be fixed relatively quickly, so I'll release after we'll work through https://github.com/tarantool/tarantool-python/issues/282 too. But pip allows to install from master or other branches anyway, if you're interested.