tarantool / test-run

Tarantool functional testing framework
14 stars 15 forks source link

Add release_disabled field to app- and unit- tests #299

Closed VitaliyaIoffe closed 3 years ago

VitaliyaIoffe commented 3 years ago

Previously if suite.ini has a release_disabled field it works only for tarantool tests. This commit allows to use it for app- and unittests suites.

Despite unittest does not take tarantool binary, unittests get version (release/debug) from the tarantool binary information.

For instance,

Add line to test-unit/suite.ini: release_disabled = broken_unicode.test

On debug version: [001] test-unit/broken_unicode.test                                   [ pass ]

On release version: [001] test-unit/broken_unicode.test                                   [ disabled ]

Closes: #199

Totktonada commented 3 years ago

First of all, sql-tap/debug_mode_only.test.lua fails now. I looked around a bit and there are several facts about it:

Since @tsafin assigned to this task I would ask him to decide what to do with the test: should we disable it now (to fix in the scope of his task) or remove at all?

tsafin commented 3 years ago

Since @tsafin assigned to this task I would ask him to decide what to do with the test: should we disable it now (to fix in the scope of his task) or remove at all?

Yes, please disable it - we will return here quite soon, and reinstate the code

Totktonada commented 3 years ago

Yes, please disable it - we will return here quite soon, and reinstate the code

Okay, I'll proceed with that, when I'll update the test-run submodule.

Totktonada commented 3 years ago

Updated the test-run submodule in tarantool in the following commits: 2.9.0-30-g7bee61531, 2.8.1-16-gb54bfb86b, 2.7.2-12-gbaa8c8212, 1.10.10-5-g047b910d5.