search

tarantool / test-run

Tarantool functional testing framework
14 stars 15 forks source link

Update and refine the readme #323

Open NickVolynkin opened 2 years ago

NickVolynkin commented 2 years ago

Preview: https://github.com/NickVolynkin/test-run/blob/update-readme/README.md

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.04%) to 63.598% when pulling ef57de9553f0cb4732dcb67719de239021327c3a on NickVolynkin:update-readme into f246567bfc444b7bee4e66d6e187da572b962cbd on tarantool:master.

Totktonada commented 2 years ago

That's really boring to write all those details. Maybe it is better to book 1,5 hours and traverse over all features and tricks of test-run known to me. We can start with reviewing the readme file and expend it beyond if time will permit. Or, maybe, a hour about user visible behaviour and a hour for internal details.

Totktonada commented 2 years ago

My comments are mostly not answered. It is in the responsibility of a developer to update all discussions before asking for a next review. Otherwise a reviewer will be obligated to re-check every point, which (s)he highlighted. It is time consuming and not profitable.

I see a temporary commit in this pull request. I expect ready-to-go (in your opinion) pull request, when a review is acquired. Please, elaborate.

After this I'll look at your answers and, if nothing will confuse me, can skip re-check of the changes. You'll wait less time for review so.

Please, take me right. I review 50-60 PRs per month. I would not able to do so without 'extra' effort from developers to make reviews simpler.

Totktonada commented 2 years ago

My comments are mostly not answered.

Still. Please, find another reviewer.