Drop setting OMP_NUM_THREADS

tarantool / test-run

Tarantool functional testing framework

14 stars 14 forks source link

Drop setting OMP_NUM_THREADS #391

Closed nshy closed 1 year ago

nshy commented 1 year ago

It was workaround before https://github.com/tarantool/tarantool/issues/2431 was fixed (see comment [1] in the issue). Now we are going to drop sort using OpenMP so it is time to drop this workaround altogether.

[1] https://github.com/tarantool/tarantool/issues/2431#issuecomment-856007551

Part of https://github.com/tarantool/tarantool/issues/3389

coveralls commented 1 year ago

Coverage: 62.854% (-0.04%) from 62.895% when pulling 7fee651020f15abf3dda24a5b75e76cab4e59908 on nshy:drop-openmp-workaround into aac77f5a20a5ed41b9459a4c934ee44c16ac6265 on tarantool:master.

Totktonada commented 1 year ago

This hunk of code is to speed up testing on tarantool versions prior to 1.7.4-260-g2e864b5a7c. Marmless, but has no sense now. I completely agree to remove it.