search

tarantool / vshard

The new generation of sharding based on virtual buckets
Other
100 stars 30 forks source link

Support memtx MVCC #334

Closed Gerold103 closed 2 years ago

Gerold103 commented 2 years ago

314

The patchset fixes a bug because of which the bucket garbage collector sometimes could ignore SENT/GARBAGE buckets when MVCC is enabled. The same without without MVCC I couldn't confirm.

Worth mentioning that I didn't test rebalancer with it. It requires to port much more tests to luatest. But I don't expect any problems. Bucket recovery could have the same issue but it also uses the generations and hence should be fixed too. It is not covered by specific tests by the same reason - too much work to port the existing tests to luatest just for that.

Totktonada commented 2 years ago

NB: Testing with the newest tarantool requires some work on the setup-tarantool action side.

Gerold103 commented 2 years ago

Bad that it is not tested on tarantool master in CI. But I don't know how CI is scripted so I better won't touch it. I can accept a PR though.