search

tarantool / vshard

The new generation of sharding based on virtual buckets
Other
100 stars 30 forks source link

Make default bucket count 30k #362

Open Gerold103 opened 2 years ago

Gerold103 commented 2 years ago

Apparently, people deploy live clusters on 3k buckets and have issues when each bucket grows to 1GB and more. It was decided to make it at least 30k default.

But changing the number in consts.lua is not enough. Firstly, need to ensure that the tests will keep using <= 3k, otherwise they will be too long. Secondly, plain number update would break existing clusters which have bucket_count cfg option omitted. Need to find a way to keep using previously configured bucket count on existing clusters. Also not clear what to do with routers - they can't even find the old bucket count, because they don't store anything.

Requested by @Mons.

R-omk commented 2 years ago

I think it's worth making the number be a power of 2. 2^15=32768

Related https://github.com/tarantool/vshard/issues/232