search

tarantool / vshard

The new generation of sharding based on virtual buckets
Other
100 stars 30 forks source link

Fixed rewrited error arguments #374

Closed vaintrub closed 1 year ago

vaintrub commented 1 year ago

This patch solves the problem when the error argument and the error name variable match, the variable is overwritten.

https://github.com/tarantool/vshard/blob/c508c8228ec81872cd246d3e062294a12d2d3e5d/vshard/error.lua#L109-L113

On line 256 we add the name key to ret, and on line 261 we overwrite it https://github.com/tarantool/vshard/blob/c508c8228ec81872cd246d3e062294a12d2d3e5d/vshard/error.lua#L255-L261

vaintrub commented 1 year ago

Thanks for the patch! Please, make the commit message comply with our styling rules: https://github.com/tarantool/tarantool/wiki/Code-review-procedure#commit-message and double-check the grammar for too visible mistakes.

In your case the title should be like error: fix conflicting member names. And the commit message should explain what and why was changed, like you did in the PR comment.

Thanks! I have corrected the commit message