search

tarantool / vshard

The new generation of sharding based on virtual buckets
Other
98 stars 29 forks source link

test: introduce router reload test #396

Closed Serpentian closed 1 year ago

Serpentian commented 1 year ago

Currently reloading from versions before commit https://github.com/tarantool/vshard/commit/dd70cfb2c5ec36ab7d5355b0024e5f6d21bb8f9f ("router: auto and manual enable/disable") doesn't work, as variables is_enabled and api_call_cache weren't handled properly. Let's set is_enabled flag to true on reload for backward compatibility. As for api_call_cache it should be set on router configuration, not its creation, as reconfiguration is invoked anyway on reload.

The commit also introduces a test, which checks availability of basic services and methods, when the router module is reloaded to the new version.

Closes https://github.com/tarantool/vshard/issues/141

NO_DOC=bugfix

Serpentian commented 1 year ago
  1. Now the test just checks basic work of master_search and discovery. What else do we want to test in reloading over versions?
  2. Is it ok to use old git infrastructure? IMO, it makes no sense to rewrite smth, that works.
Serpentian commented 1 year ago

@Gerold103 smth strange is going on with some of our storage/* tests on CI. Sometimes they just hang on the following line:

test_run = require('test_run').new()

It's already the third time I see this in the last two weeks. Currently it was reproduced on the 2.8 branch. Do you have any ideas for the reason of such behavior?