tarantool / vshard

The new generation of sharding based on virtual buckets
Other
99 stars 30 forks source link

log: 'deploying exports' message has no core version #465

Closed Totktonada closed 10 months ago

Totktonada commented 11 months ago

Let's look on the code.

https://github.com/tarantool/vshard/blob/5bfe03b48839863c7a0098d27dbbee1d54890562/vshard/storage/exports.lua#L44-L48

https://github.com/tarantool/vshard/blob/5bfe03b48839863c7a0098d27dbbee1d54890562/vshard/storage/exports.lua#L59-L60

The exports.core_version field is always an empty string.

# tarantool> lvutil = require('vshard.util')
# tarantool> lvutil.core_version
---
- id_middle: 1
  rel_type: entrypoint
  id_minor: 0
  id_major: 3
  id_commit: 9
  rel_num: 0
...
# tarantool> table.concat(lvutil.core_version, '.')
---
-
...

table.concat() concetenates an array, but not a map.

Serpentian commented 11 months ago

https://github.com/tarantool/vshard/pull/463