Closed menghif closed 1 month ago
I love how clean this looks @menghif!
Question: can we do something about how the overflow
gets applied, so it stays limited to the models vs. the entire menu. On providers with a lot of models, you lose track easily:
https://github.com/tarasglek/chatcraft.org/assets/427398/15476be0-0cc1-48c1-bbbc-693736cc2e17
If that's too complicated, we can leave that for a follow-up.
@humphd Yesterday I tried changing the overflow to only the Models list but I wasn't sure how it would behave with a long list of providers. I only tested it with up to 3.
Latest commit: |
f1d30e9
|
Status: | ✅ Deploy successful! |
Preview URL: | https://edc57634.console-overthinker-dev.pages.dev |
Branch Preview URL: | https://issue-641.console-overthinker-dev.pages.dev |
This works well for me (sorry for lower video quality, had to reduce it to fit in 10M):
https://github.com/tarasglek/chatcraft.org/assets/427398/d44c79c7-60cd-48de-98ab-cc8c480ea075
I'd say "ship it."
Anyone else have feedback before we merge?
One last thing I noticed from your video is that I messed up the Menu placement. It should be top-end
. Fixed it now!
this a nice improvement
This is a bit weird in mobile as we now cover up search results by keyboard on ios :(
This is a bit weird in mobile as we now cover up search results by keyboard on ios :(
I'll look into how to fix it.
Fixes #641
This PR moves the Providers list above the Models list in the Ask menu.
Additionally, I changed the selection icon to a checkmark for better clarity. I aligned the menu to its button and changed the variant of the search bar.