tarasglek / chatcraft.org

Developer-oriented ChatGPT clone
https://chatcraft.org/
MIT License
147 stars 26 forks source link

Change Providers/Models order in Ask menu #642

Closed menghif closed 1 month ago

menghif commented 1 month ago

Fixes #641

This PR moves the Providers list above the Models list in the Ask menu.

Additionally, I changed the selection icon to a checkmark for better clarity. I aligned the menu to its button and changed the variant of the search bar.

humphd commented 1 month ago

I love how clean this looks @menghif!

Question: can we do something about how the overflow gets applied, so it stays limited to the models vs. the entire menu. On providers with a lot of models, you lose track easily:

https://github.com/tarasglek/chatcraft.org/assets/427398/15476be0-0cc1-48c1-bbbc-693736cc2e17

If that's too complicated, we can leave that for a follow-up.

menghif commented 1 month ago

@humphd Yesterday I tried changing the overflow to only the Models list but I wasn't sure how it would behave with a long list of providers. I only tested it with up to 3.

cloudflare-pages[bot] commented 1 month ago

Deploying chatcraft-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: f1d30e9
Status: ✅  Deploy successful!
Preview URL: https://edc57634.console-overthinker-dev.pages.dev
Branch Preview URL: https://issue-641.console-overthinker-dev.pages.dev

View logs

humphd commented 1 month ago

This works well for me (sorry for lower video quality, had to reduce it to fit in 10M):

https://github.com/tarasglek/chatcraft.org/assets/427398/d44c79c7-60cd-48de-98ab-cc8c480ea075

I'd say "ship it."

Anyone else have feedback before we merge?

menghif commented 1 month ago

One last thing I noticed from your video is that I messed up the Menu placement. It should be top-end. Fixed it now!

tarasglek commented 1 month ago

this a nice improvement

tarasglek commented 4 weeks ago

This is a bit weird in mobile as we now cover up search results by keyboard on ios :(

menghif commented 3 weeks ago

This is a bit weird in mobile as we now cover up search results by keyboard on ios :(

I'll look into how to fix it.