search

taraslayshchuk / es2csv

Export from an Elasticsearch into a CSV file
Apache License 2.0
510 stars 191 forks source link

Add explicit authentication #17

Closed pandaadb closed 7 years ago

pandaadb commented 7 years ago

Hi,

I created this pull request because I ran into the following issue, documented here:

https://github.com/elastic/elasticsearch-py/issues/470#issuecomment-256091032

It appears that python does not like the have hash signs in passwords when using the recommended RFC-1738. So, for example, a password like "myPassword#" will break authentication with ES.

This PR adds the following:

Elasticsearch will prefer RFC-style auth when both are specified. I could be convinced to add validation for this case (where both are specified). This version does not have that as I saw it unnecessary for my purposes :)

Let me know your thoughts!

-- Artur

taraslayshchuk commented 7 years ago

Good job! Thanks for resolution this issue.

pandaadb commented 7 years ago

Yey :) No problem!

Do you have an estimate on when you would release it?

taraslayshchuk commented 7 years ago

There is one PR #13 which almost complete and one issue #10 which I want try to fix.