search

tarasn / pomodairo

Automatically exported from code.google.com/p/pomodairo
0 stars 0 forks source link

Time zone conflict with Pomodairo clock #52

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Open Date/Time Settings
2. Change time zone to India (GMT+5:30)
3. Open Pomodairo and start the timer

What is the expected output? What do you see instead?
I see 30 minutes automatically added to the countdown timer. I have no idea
why this happens but Pomodairo functions normally i.e. after the Pomodoro
has counted down, the alarm sounds. It's just that there are 30 extra
minutes shown on the clock.

What version of the product are you using? On what operating system?
Pomodairo v1.7 on Windows 7 Home Premium

Please provide any additional information below.
If I set my time zone to something like US Central Time (GMT-6:00),
Pomodairo functions as expected.

Original issue reported on code.google.com by siddhart...@gmail.com on 4 Jun 2010 at 4:30

GoogleCodeExporter commented 9 years ago 
I am facing exactly the same issue. This app is great but this issue keeps me 
from using it

Original comment by amol...@gmail.com on 28 Jul 2010 at 10:27

GoogleCodeExporter commented 9 years ago 
I had the same problem in my system. My TimeZone is -4:30. The error happens 
when the time zone has an offset in minutes (30 in this case). I really wanted 
to use this program, so I decided to fix it myself.

At the end it turned out to be really simple. Just two lines of code modified 
in the file "src/com/pomodairo/components/timer.mxml". The lines in the current 
version (rev.115) are: 170,193.

All you have to change is the function used to get the minute count: from 
"minutes" to "minutesUTC". And while we are at it, why not change as well the 
one to get the seconds at lines 171 and 194 from "seconds" to "secondsUTC".

Hope it helps. I guess this will be fixed for version 1.8. PS. how do one sends 
code patches to the owners of this project.

Original comment by omeg...@gmail.com on 25 Aug 2010 at 11:08

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
UPDATE: the functions I modified where "updateTimer" and "updateBreakTimer". 
That fixed the problem with the main timer, but I missed one detail: the title 
of the app.
To fix it too, you just need to do the same but for the function 
"updateAppTitle".
This is, change "minutes" to "minutesUTC".

Original comment by omeg...@gmail.com on 25 Aug 2010 at 11:30

GoogleCodeExporter commented 9 years ago 
Thanks a ton!
Is it possible to attach the corrected version of the file. I am a non-techie 
here
Hope not asking too much

Original comment by amol...@gmail.com on 25 Aug 2010 at 11:33

GoogleCodeExporter commented 9 years ago 
You would need to download the source code with svn, modify the file 
"src/com/pomodairo/components/timer.mxml" and then compile it with Flex. If you 
don't want to build it nor wait for an official build with this bug fixed, this 
is my personal build. Use it at your own risk.

Original comment by omeg...@gmail.com on 25 Aug 2010 at 12:27

Attachments:

GoogleCodeExporter commented 9 years ago 
Also, before installing this you should uninstall the other one.

Original comment by omeg...@gmail.com on 25 Aug 2010 at 12:30

GoogleCodeExporter commented 9 years ago 
thanks a ton omega!

Original comment by amol...@gmail.com on 25 Aug 2010 at 12:36

GoogleCodeExporter commented 9 years ago 
Will try and merge this into trunk.

Original comment by fredrikj...@gmail.com on 4 Nov 2010 at 10:23

GoogleCodeExporter commented 9 years ago 
Fixed in trunk

Original comment by fredrikj...@gmail.com on 4 Nov 2010 at 10:28

GoogleCodeExporter commented 9 years ago 
It's fixed only for the main timer. The break timer is still wrong.

Original comment by omeg...@gmail.com on 27 Dec 2010 at 8:23