tarb / betfair_data

Fast Python Betfair historical data file parser
https://betfair-datascientists.github.io/tutorials/jsonToCsvRevisited/
MIT License
38 stars 5 forks source link

Rust install required to install Module via PIP #10

Open vaanderal opened 2 years ago

vaanderal commented 2 years ago

Relatively simple quality of life update suggested, in the pre-requisites section of the README doco suggest adding:

Install latest version of Rust:

https://www.rust-lang.org/tools/install

Ensure it is added to the path variable

Open Powershell Run this command:

$env:Path += ';C:\Users\<USER>\.cargo\bin'

Replace with your username.

Proceed to install.

Also does not seem to work with python 3.10.x, had to downgrade to 3.7.12 to operate

tarb commented 2 years ago

I'm really not familiar with Python development or package management, so I don't know what determines pip trying to build from source vs using the packaged binary wheels - but the pre-built wheels are there, and building from source shouldn't be required. I've found that pip install --prefer-binary betfair_data seems to push it to use the prebuilt wheels. Also if you want, you can look at the github actions for how the wheels are built and released if theres any interest in the build process.

Realistically the only people who I would expect to want to build from source will be people already familiar with the Rust development workflow, and to that end there isn't really anything unique or interesting that sets it apart from any other pyo3/maturin library - but I could see the benefit in maybe adding a small inclusion on the bottom of the readme to help people get started and point them to the (excellent) pyo3 documentation.

As for not working with 3.10 I'd love any more information you have on that. It should be compatible and that's what I internally used to create it - so i'd be happy to help you get to the bottom of that.