tarbaevbb / wnd-charm

Automatically exported from code.google.com/p/wnd-charm
0 stars 0 forks source link

large feature set sig files contain features with identical names #35

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Run a wndchrm train -l on any tiff
2. Open up the resulting sig
3. Look within the file for the "Feature DistHist"
4. Notice that there are 10 signatures all with the same name "Feature DistHist"

What is the expected output? What do you see instead?
This only happens when calculating the large feature set.  Note that when 
looking in FeatureNames.cpp, where all the old-style feature names are mapped 
to the new normalized style feature names, the features in question were 
represented in the small feature set, but not the large feature set.

What version of the product are you using? On what operating system?
wndchrm-1.31 branch, and trunk. Mac OS 10.6.8

Please provide any additional information below.
The following changes are required:
1. In signatures.cpp, signatures::CompGroupA() line 628, call Add() with a 
first argument of "buffer", and not the string literal that is in there 
currently "Feature DistHist"
2. In FeatureNames.cpp, add the the patterns that would appear to the map of 
old style names to new style names:
"Feature dist histogram bin n"

Original issue reported on code.google.com by christop...@nih.gov on 15 Nov 2011 at 9:08

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r280.

Original comment by christop...@nih.gov on 15 Nov 2011 at 9:17

GoogleCodeExporter commented 9 years ago
I committed a fix for this into the trunk, revision 280.

Original comment by christop...@nih.gov on 15 Nov 2011 at 9:18