search

tarcode-apps / BatteryMode

Windows Battery Indicator replacement
https://bmode.tarcode.ru
Other
255 stars 12 forks source link

Add Italian language #20

Closed bovirus closed 3 years ago

bovirus commented 3 years ago

@artar94 @kjen93

Add Italian language - New version. I hope that now is OK.

artar94 commented 3 years ago

@bovirus Please download the beta version here https://dl.tarcode.ru/beta/4.1.0.155/ and verify if your localization is displayed correctly. If you need to make some changes, please do not reopen Pull Request, just commit your changes to the same branch.

bovirus commented 3 years ago

I founf a strange issue in the instalelr. I select Italian at first step but during the installation (64bit) appear this window

image

that of course is not italian. Note: this window appear also if I select other language (ex. French).

bovirus commented 3 years ago

How can modify the file in the current PR?

kjen93 commented 3 years ago

How can modify the file in the current PR?

You can modify it the same way you did it before creating this Pull Request. When you edit a file in your repository https://github.com/bovirus/BatteryMode, this change is automatically added to this Pull Request

kjen93 commented 3 years ago

@bovirus Please try the following beta version with fixed installer https://dl.tarcode.ru/beta/4.1.0.157/

bovirus commented 3 years ago

@kjen93

I modified and fixed some issues in my current fork. Please apply the changes to your repository.

image

It seems that I found a string not included in language file (Generic PnP moniotr). Please check screenshot.

artar94 commented 3 years ago

@bovirus Please try the following beta version https://dl.tarcode.ru/beta/4.1.0.159/ The string Generic PnP moniotr as well as the names of the power schemes are obtained from the system and are not localized. It would also be great if you make lines 1281, 1381 and 1391 shorter.

bovirus commented 3 years ago

@artar94 I reduce the lenght of strings requested. Please check if it's ok (as lenght) now.

artar94 commented 3 years ago

@bovirus Please try the following beta version https://dl.tarcode.ru/beta/4.1.0.161/ Could these lines be made even shorter? image

bovirus commented 3 years ago

artart94

I made the changes to reduce the string lenght. If you can I propose an improve of space available in the GUI

Move "Add condition" on the left Move "Clear" up near to "Add condition" Enlarge "left drop down list" width Move "right drop down list" on the right and increase drop down width

Please check original and revised. I maximized the space available in GUI

original GUI image

revised GUI image

artar94 commented 3 years ago

@bovirus Please try the following beta version https://dl.tarcode.ru/beta/4.1.0.163/ I increased the width of the input fields and now everything fits: image Your offer will not work because there can be many triggers and conditions.

bovirus commented 3 years ago

@artar94

Thanks. I believe that it's a very good improvemnet for all languages. Not English strings many times are longer than English... I beleive that could be the right time for a new release.

artar94 commented 3 years ago

@bovirus The release will be a little later, we have more changes that should go into it. Thanks for the translation!

bovirus commented 3 years ago

@artar94

Thanks. Please take your time. ;-)

If you include it in your repository I can delete my fork.

VenusGirl commented 3 years ago

BatteryMode version 4.1.0.165 works fine, everything works perfectly fine.

Thank you.