search

tarcode-apps / BatteryMode

Windows Battery Indicator replacement
https://bmode.tarcode.ru
Other
253 stars 12 forks source link

Chinese Simplified Translation #40

Closed jerrylususu closed 2 years ago

jerrylususu commented 2 years ago

This is a great app and with Chinese (Simplified) translation it should reach a border range of users. Hope this helps.

artar94 commented 2 years ago

@jerrylususu Thank you for your contribution to the development of Battery Mode! Please try this beta version https://dl.tarcode.ru/beta/4.1.1.173 and tell me if everything is displayed well?

jerrylususu commented 2 years ago

Hi! It mostly looks fine (with a minor fix), but there seems to be some strange artifact that I am not sure is expected. Please check the read boxes in the following screenshot. During my translation, I am not sure what's the purpose of ampersand, followed by a letter. Is that used for keyboard shortcuts? Are those letters expected to be displayed?

Update: It seems that these ampersands indicate mnemonic key, according to ms docs. Beside the first one (in the tabs) others I think are acceptable, but still I am not sure if the one in the tab should be there. String 41 should control this.

image

artar94 commented 2 years ago

@jerrylususu These letters were previously used in the context menu, but now they are superfluous. Please remove them if they are not used in the context menu.

jerrylususu commented 2 years ago

Thanks for that explanation. I just removed them in the newest commit. You may need to release a new beta version to see if that works. (Also the Chinese Traditional translation in #41) needs to be updated.

artar94 commented 2 years ago

@jerrylususu Please try the new beta version https://dl.tarcode.ru/beta/4.1.1.175 By the way, these letters were displayed due to the fact that they were written in lower case.

jerrylususu commented 2 years ago

Thanks for your fast response. I just checked the new beta version and as for Chinese Simplified translation all seems fine. Currently there is nothing more to add or change from my side. If you feel happy about it you may close the issue.