tardipede / concatipede

Other
0 stars 0 forks source link

Address notes about `LazyData` in `DESCRIPTION` and the possibly invalid URIs #4

Closed matthieu-bruneaux closed 3 years ago

matthieu-bruneaux commented 3 years ago

I removed the LazyData line in DESCRIPTION and I altered the way Excel screenshots were inserted in the vignette to avoid the invalid URIs note.

I ran a check with devtools::check_win_devel() which only generated the note about it being a new submission and the spelling of "fasta" (https://win-builder.r-project.org/826C2RKs93Xo). Results of rhub checks (below) also show only the new submission bit, the spelling of "fasta", and in one case the slightly long run time of an example.

Rhub check report, started on 2021-08-01 13:21:22

Check for fedora-clang-devel

── concatipede 1.0.0: NOTE

  Build ID:   concatipede_1.0.0.tar.gz-0020018a824b447ab78aa9f527fa5afc
  Platform:   Fedora Linux, R-devel, clang, gfortran
  Submitted:  19m 22.4s ago
  Build time: 19m 9.5s

❯ checking CRAN incoming feasibility ... NOTE
  Maintainer: ‘Matteo Vecchi <matteo.vecchi15@gmail.com>’

  New submission

  Possibly mis-spelled words in DESCRIPTION:
    Fasta (2:30)

❯ checking examples ... NOTE
  Examples with CPU (user + system) or elapsed time > 5s
                   user system elapsed
  auto_match_seqs 6.931  0.167   1.781

0 errors ✔ | 0 warnings ✔ | 2 notes ✖

Check for windows-x86_64-devel

── concatipede 1.0.0: NOTE

  Build ID:   concatipede_1.0.0.tar.gz-cbaea42a6c6f4f8f9e5d7b73b284d8a8
  Platform:   Windows Server 2008 R2 SP1, R-devel, 32/64 bit
  Submitted:  4m 17.8s ago
  Build time: 4m 13s

❯ checking CRAN incoming feasibility ... NOTE
  Maintainer: 'Matteo Vecchi <matteo.vecchi15@gmail.com>'
  New submission

  Possibly mis-spelled words in DESCRIPTION:

    Fasta (2:30)

0 errors ✔ | 0 warnings ✔ | 1 note ✖

Check for macos-highsierra-release

── concatipede 1.0.0: OK

  Build ID:   concatipede_1.0.0.tar.gz-a3c602bb612c44a8b17d8814d05ecdc5
  Platform:   macOS 10.13.6 High Sierra, R-release, brew
  Submitted:  2m 17.1s ago
  Build time: 1m 29.7s

0 errors ✔ | 0 warnings ✔ | 0 notes ✔

Check for ubuntu-gcc-release

── concatipede 1.0.0: NOTE

  Build ID:   concatipede_1.0.0.tar.gz-194344c23b084247b5485a821686bbcc
  Platform:   Ubuntu Linux 20.04.1 LTS, R-release, GCC
  Submitted:  18m 23.4s ago
  Build time: 17m 53.6s

❯ checking CRAN incoming feasibility ... NOTE
  Maintainer: ‘Matteo Vecchi <matteo.vecchi15@gmail.com>’

  New submission

  Possibly mis-spelled words in DESCRIPTION:
    Fasta (2:30)

0 errors ✔ | 0 warnings ✔ | 1 note ✖

End of report, 2021-08-01 14:06:37