tardis-sn / stardis

TARDIS stellar radiative transfer
https://tardis-sn.github.io/stardis/
11 stars 15 forks source link

Make Conda Lockfiles Reproducible, Update Numpy Version, Add Cupy as Dependency #110

Closed smokestacklightnin closed 1 year ago

smokestacklightnin commented 1 year ago

:pencil: Description

Type: :beetle: bugfix | :rocket: feature

This pull request does five main things:

  1. Make conda lockfiles reproducible so we can add dependencies in the future
  2. Add Cupy as a dependency for CUDA installs
  3. Update numpy from version 1.19.5 to >=1.20 because Cupy requires it
  4. Update the documentation to include how to reproduce lockfiles and updated installation instructions.
  5. Fix naming error for name of cache for unit tests on GitHub Workflows.

This also seems to effectively fix Issue #75

This can be considered a followup to this commit.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

codecov[bot] commented 1 year ago

Codecov Report

Merging #110 (3eadc88) into main (d0776f1) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 3eadc88 differs from pull request most recent head 5ef48ee. Consider uploading reports for the commit 5ef48ee to get more accurate results

@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   34.04%   34.04%           
=======================================
  Files          17       17           
  Lines         658      658           
=======================================
  Hits          224      224           
  Misses        434      434           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

smokestacklightnin commented 1 year ago

Not sure why there are larger .yml files that are the same as lock files.

A couple reasons:

  1. It mirrors what is present in the TARDIS repo
  2. This follows the basic usage from the conda-lock documentation