search

tardis-sn / stardis

TARDIS stellar radiative transfer
https://tardis-sn.github.io/stardis/
11 stars 15 forks source link

Rip out read_marcs_to_fv() #115

Closed jvshields closed 1 year ago

jvshields commented 1 year ago

The new MARCS model reader makes the read_marcs_to_fv() function redundant. It also builds a physically incorrect model and should not be used going forward. Benchmarking and other parts of the code that use this function should change over to the model reader to construct a stellar model when PR 112 gets merged.

smokestacklightnin commented 1 year ago

Perhaps in the meantime we can at least add a deprecation warning