Fix breaking benchmark pipeline

tardis-sn / stardis

TARDIS stellar radiative transfer

https://tardis-sn.github.io/stardis/

11 stars 15 forks source link

Fix breaking benchmark pipeline #128

Closed light2802 closed 1 year ago

light2802 commented 1 year ago

:pencil: Description

Type: :beetle: bugfix

An incorrect config parameter was passed to one of the benchmarks which was causing the benchmark workflow to fail.

:vertical_traffic_light: Testing

How did you test these changes?

[x] Testing pipeline
[ ] Other method (describe)
[ ] My changes can't be tested (explain why)

:ballot_box_with_check: Checklist

[ ] I requested two reviewers for this pull request
[ ] I updated the documentation according to my changes
[ ] I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

codecov[bot] commented 1 year ago

Codecov Report

Merging #128 (2f00616) into main (384031f) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 2f00616 differs from pull request most recent head 9ff7f2f. Consider uploading reports for the commit 9ff7f2f to get more accurate results

@@           Coverage Diff           @@
##             main     #128   +/-   ##
=======================================
  Coverage   72.75%   72.75%           
=======================================
  Files          21       21           
  Lines         690      690           
=======================================
  Hits          502      502           
  Misses        188      188

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

tardis-bot commented 1 year ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing main (384031f447ba757f00bff0a8f0e99d80720f9574) and the latest commit (9ff7f2f4ea1e4128134d20c8aeefae4ab35d5bdc). Here are the logs produced by ASV. Results can also be downloaded as artifacts here. Significantly changed benchmarks:

```diff ```

All benchmarks:

```diff All benchmarks: before after ratio [384031f4] [9ff7f2f4] 13.6±0.1s 13.4±0.1s 0.99 run_stardis.BenchmarkStardis.time_calc_alpha 269±7ms 252±2ms 0.94 run_stardis.BenchmarkStardis.time_raytrace 18.9±0.2s 18.4±0.2s 0.97 run_stardis.BenchmarkStardis.time_run_stardis ```