add w2 in the small and large delta tau case

tardis-sn / stardis

TARDIS stellar radiative transfer

https://tardis-sn.github.io/stardis/

11 stars 15 forks source link

add w2 in the small and large delta tau case #132

Closed jvshields closed 1 year ago

jvshields commented 1 year ago

:pencil: Description

Type: :beetle: bugfix

The W2 weight was not calculated in the large and small tau case, so the code would crash in those cases. This adds the appropriate weight calculation for W2. This branch was created on top of the radiation field branch so that should probably be merged first for ease of conflicts.

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

[ ] Testing pipeline
[ ] Other method (describe)
[ ] My changes can't be tested (explain why)

:ballot_box_with_check: Checklist

[ ] I requested two reviewers for this pull request
[ ] I updated the documentation according to my changes
[ ] I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

codecov[bot] commented 1 year ago

Codecov Report

Merging #132 (a7c825d) into main (1320de3) will decrease coverage by 0.20%. The diff coverage is 0.00%.

:exclamation: Current head a7c825d differs from pull request most recent head a024da0. Consider uploading reports for the commit a024da0 to get more accurate results

@@            Coverage Diff             @@
##             main     #132      +/-   ##
==========================================
- Coverage   76.13%   75.93%   -0.20%     
==========================================
  Files          27       27              
  Lines         771      773       +2     
==========================================
  Hits          587      587              
- Misses        184      186       +2

Files Changed	Coverage Δ
...is/radiation_field/radiation_field_solvers/base.py	`31.25% <0.00%> (-1.36%)`	:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

tardis-bot commented 1 year ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing main (1320de368832125747ece4adabeaf27dc212225c) and the latest commit (a024da0d76d2e20cb669328148cc26d413edce9b). Here are the logs produced by ASV. Results can also be downloaded as artifacts here. Significantly changed benchmarks:

```diff ```

All benchmarks:

```diff All benchmarks: before after ratio [1320de36] [a024da0d] failed failed n/a run_stardis.BenchmarkStardis.time_calc_alpha failed failed n/a run_stardis.BenchmarkStardis.time_raytrace failed failed n/a run_stardis.BenchmarkStardis.time_run_stardis ```