search

tardis-sn / stardis

TARDIS stellar radiative transfer
https://tardis-sn.github.io/stardis/
11 stars 15 forks source link

Shortlist calculation #149

Closed jvshields closed 10 months ago

jvshields commented 11 months ago

This calculates opacities with the short form of a vald linelist. Allows us to directly compare to korg (since as far as we can tell they can't use the long-form linelist). Also modifies the config schema to accept a shortlist specification so that the new calculation can be used.

At some point soon it'd be nice to get proper regression tests going, since that's the easiest way to test the plasma. This seems to me like the best way to test the different plasmas and calculated opacities.

codecov[bot] commented 11 months ago

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (b560322) 66.73% compared to head (7d77bbf) 67.40%. Report is 3 commits behind head on main.

Files Patch % Lines
stardis/plasma/base.py 19.35% 25 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #149 +/- ## ========================================== + Coverage 66.73% 67.40% +0.67% ========================================== Files 27 30 +3 Lines 1016 1169 +153 ========================================== + Hits 678 788 +110 - Misses 338 381 +43 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jvshields commented 10 months ago

I agree test coverage would be good, but I think the right way to add a test for this is beyond the scope of this PR. I'd like to set up a model fixture which can be used for a couple things (including regression tests). I'm planning to do that next but didn't want to add that whole infrastructure here.