tardis-sn / stardis

TARDIS stellar radiative transfer
https://tardis-sn.github.io/stardis/
11 stars 15 forks source link

attempt benchmark fix #153

Closed jvshields closed 10 months ago

jvshields commented 10 months ago

I tracked down a bug in the benchmarks - why they haven't been able to run for awhile.

It's a small change, but the config is necessary now to create the plasma and that wasn't passed along to the benchmark model creation. Hopefully the benchmarks will run again now with this.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (df0dd0c) 68.68% compared to head (e6ed319) 68.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #153 +/- ## ======================================= Coverage 68.68% 68.68% ======================================= Files 30 30 Lines 1140 1140 ======================================= Hits 783 783 Misses 357 357 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tardis-bot commented 10 months ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing main (df0dd0cf266d0b5e9282eea9b4dc5813d522fb9f) and the latest commit (e6ed3198a90f14c18e147f17652e0ae072dbcc61). Here are the logs produced by ASV. Results can also be downloaded as artifacts here. Significantly changed benchmarks:

```diff ```

All benchmarks:

```diff All benchmarks: before after ratio [df0dd0cf] [e6ed3198] 443±3ms 440±3ms 0.99 run_stardis.BenchmarkStardis.time_calc_alpha 12.2±0.06ms 12.1±0.07ms 1.00 run_stardis.BenchmarkStardis.time_raytrace 1.89±0.01s 1.88±0.01s 0.99 run_stardis.BenchmarkStardis.time_run_stardis ```