search

tardis-sn / stardis

TARDIS stellar radiative transfer
https://tardis-sn.github.io/stardis/
11 stars 15 forks source link

fix linear stark parameter to match paper source #157

Closed jvshields closed 10 months ago

jvshields commented 10 months ago

Seems like we might have a slightly incorrect linear broadening treatment due to a typo. This PR should fix that.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2e61ddb) 67.55% compared to head (1bfed14) 67.55%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #157 +/- ## ======================================= Coverage 67.55% 67.55% ======================================= Files 30 30 Lines 1159 1159 ======================================= Hits 783 783 Misses 376 376 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

andrewfullard commented 10 months ago

How much impact does this have on the spectrum? It looks to be about 15% numerically for this specific parameter.

jvshields commented 10 months ago

How much impact does this have on the spectrum? It looks to be about 15% numerically for this specific parameter.

Honestly for any lines I've investigated so far. This difference is only as important as linear stark broadening is for any given line, and it's usually pretty subdominant.