tardis-sn / stardis

TARDIS stellar radiative transfer
https://tardis-sn.github.io/stardis/
11 stars 15 forks source link

Addressing comments #160

Closed haydenmonk closed 9 months ago

haydenmonk commented 10 months ago

:pencil: Description

Type: :beetle: bugfix | :rocket: feature | :biohazard: breaking change | :vertical_traffic_light: testing | :memo: documentation | :roller_coaster: infrastructure

Write a complete description of your changes, including the necessary context or any piece of information required to understand your work. Added black formatting extension, moved from import lib_resources to Pathlib, renamed my fixture to be more descriptive Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

jvshields commented 10 months ago

Actually, maybe create one more PR trying again building on top of current upstream main. I've only just realized that I added some extra testing infrastructure that you don't have here. Specifically, there's a MARCS_TEST_FPATH constant that you should just use to build your model. If you look at https://github.com/tardis-sn/stardis/blob/main/stardis/io/model/tests/test_model_io.py, (this is the same file on upstream/main) it should be clear. I set up the better structure that you're implementing for the MESA model, but not the MARCS one.