tardis-sn / stardis

TARDIS stellar radiative transfer
https://tardis-sn.github.io/stardis/
11 stars 15 forks source link

Investigate continuum deficit #168

Closed jvshields closed 9 months ago

jvshields commented 9 months ago

I think our implementation of van noort 2011 was incorrect. I've updated the equation to accurately follow what is detailed in the paper. This seems to largely fix the continuum difference in the optical. In comparison to the solar luminosity in this wavelength regime, it improves the integrated flux from about 10% off to about 1% off.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (5fd5a8f) 68.28% compared to head (5a262e7) 68.34%.

Files Patch % Lines
...is/radiation_field/radiation_field_solvers/base.py 0.00% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #168 +/- ## ========================================== + Coverage 68.28% 68.34% +0.05% ========================================== Files 31 31 Lines 1154 1153 -1 ========================================== Hits 788 788 + Misses 366 365 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jvshields commented 9 months ago

This branch was built on top of #167 so we should merge that one first.

jvshields commented 9 months ago

Is this testable? Can the equation this is all based on be part of the docstring?

The docstring points to the paper as well as the relevant equations, but it'd be a bit much for a docstring. This is the relevant bit of the paper

Screenshot 2024-02-12 at 3 07 10 PM

As for testability, this takes us between these two screenshots

Screenshot 2024-02-12 at 3 08 50 PM Screenshot 2024-02-12 at 3 09 25 PM

so what I'm using as a test is just the low resolution flux of the solar spectrum (and korg).