search

tardis-sn / stardis

TARDIS stellar radiative transfer
https://tardis-sn.github.io/stardis/
11 stars 15 forks source link

Further benchmarking #170

Closed jvshields closed 9 months ago

jvshields commented 9 months ago

This PR should cleanup the benchmarking run a little bit, as well as add a few more benchmarks. Not quite done yet, but I want to see if it runs with the github runners.

tardis-bot commented 9 months ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing main (348be6a0f4d7accc24b3424b6de3b4fba6e84b25) and the latest commit (ca9a41e8b9dbb22571b20b7b79368df6280cb67f). Here are the logs produced by ASV. Results can also be downloaded as artifacts here. Significantly changed benchmarks:

```diff ```

All benchmarks:

```diff All benchmarks: before after ratio [348be6a0] [ca9a41e8] 1.43±0.01ms 1.43±0.01ms 1.00 run_stardis.BenchmarkStardis.time_calc_alpha_file 1.79±0.01s 1.81±0.02s 1.01 run_stardis.BenchmarkStardis.time_calc_alpha_line_at_nu 654±5ms 655±6ms 1.00 run_stardis.BenchmarkStardis.time_create_plasma 113±0.3ms 113±1ms 1.00 run_stardis.BenchmarkStardis.time_raytrace 3.91±0s 3.90±0.01s 1.00 run_stardis.BenchmarkStardis.time_run_stardis ```
codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (348be6a) 68.09% compared to head (ca9a41e) 68.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #170 +/- ## ======================================= Coverage 68.09% 68.09% ======================================= Files 31 31 Lines 1163 1163 ======================================= Hits 792 792 Misses 371 371 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jvshields commented 9 months ago

Looks good. Benchmarks are assuming the marcs model, I see?

That's correct. It was definitely just an, easiest on-hand model type thing that shouldn't make much of a difference for by-commit benchmarking.