Closed jvshields closed 9 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
a1c7f38
) 68.34% compared to head (f05812e
) 68.39%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
*beep* *bop* Hi human, I ran benchmarks as you asked comparing main (a1c7f386a192fa50abe3b4a37828705c21797f2e) and the latest commit (f05812ec800a276638329b22581dbe0c5837a95f). Here are the logs produced by ASV. Results can also be downloaded as artifacts here. Significantly changed benchmarks:
All benchmarks:
Hydrogen lines are much broader than virtually all other lines in a stellar spectrum. If you let hydrogen ignore the broadening range that restricts the calculations of other lines, then you get to use a much stricter broadening range for all the rest of the lines. This allows for some pretty powerful speedups reducing the number of line calculations by a factor of 3 to 10 while still getting accurate spectra.
The PR also includes a small line opacity calculation restructure by moving an if statement checking for a broadening mask outside of the frequency for loop.