search

tardis-sn / stardis

TARDIS stellar radiative transfer
https://tardis-sn.github.io/stardis/
11 stars 15 forks source link

Migrate to tardis composition #188

Closed jvshields closed 5 months ago

jvshields commented 5 months ago

Switch over stardis to using the shared tardis Composition class.

There's also some small cleanups. Fixed a lot of inconsistent spacing in the broadening test file, and got rid of hydrogen mass as an input to some broadening functions in favor of just passing in a constant.

I've also included a fix for the broken benchmarks (unpinning the ASV version) but I don't think that will propagate into the github workflow for this PR because I believe it executes the workflow specified in the main branch.

tardis-bot commented 5 months ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing main (74ce810af152e755e2a97af80b3163ec6a240f71) and the latest commit (f1fa39ca7e8ea110ea10ff977a0612b87be8f2db). Here are the logs produced by ASV. Results can also be downloaded as artifacts here. Significantly changed benchmarks:

```diff · Benchmark list file .asv/results/benchmarks.json missing! Use `asv run --bench just-discover` to regenerate benchmarks.json ```

All benchmarks:

```diff · Benchmark list file .asv/results/benchmarks.json missing! Use `asv run --bench just-discover` to regenerate benchmarks.json ```