tardis-sn / stardis

TARDIS stellar radiative transfer
https://tardis-sn.github.io/stardis/
11 stars 15 forks source link

Add geometry #99

Closed jvshields closed 1 year ago

jvshields commented 1 year ago

And also updating marcs reader to read files that are not gzipped.

Not fully hooked up yet. Still need to replace the read_marcs_to_fv() function completely when the newly read in model can handle everything that it does.

Cell length is also still not correct, because it should be called something else because we don't have cells.

codecov[bot] commented 1 year ago

Codecov Report

Merging #99 (af9ce3b) into main (3b528a5) will increase coverage by 0.33%. The diff coverage is 63.15%.

:exclamation: Current head af9ce3b differs from pull request most recent head f124472. Consider uploading reports for the commit f124472 to get more accurate results

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   34.66%   34.99%   +0.33%     
==========================================
  Files          15       16       +1     
  Lines         603      623      +20     
==========================================
+ Hits          209      218       +9     
- Misses        394      405      +11     
Impacted Files Coverage Δ
stardis/plasma/base.py 43.93% <0.00%> (ø)
stardis/transport/base.py 25.49% <0.00%> (ø)
stardis/model/base.py 16.27% <33.33%> (+0.89%) :arrow_up:
stardis/model/geometry/radial1d.py 66.66% <66.66%> (ø)
stardis/io/model/marcs.py 90.76% <75.00%> (-9.24%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more