search

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
202 stars 405 forks source link

last_interaction_types for the r_packets in single_packet_loop.py don't correspond to interaction types in interaction.py #1766

Open Rodot- opened 3 years ago

Rodot- commented 3 years ago

Describe the bug last_interaction_types for the r_packets in single_packet_loop.py don't correspond to interaction types in interaction.py. Currently the last_interaction_type is set to an integer rather than the enumerated interaction types found in interaction.py. Updating this may affect the visualization code, but should be changed for clarity

Additional context

jaladh-singhal commented 2 years ago

Related: https://github.com/tardis-sn/tardis/issues/1396

roshansingh12 commented 1 year ago

Hi @Rodot- if it is not resolved yet, I can work on this. Thank you

Rodot- commented 1 year ago

I believe it is not so that would be great if you try out resolving this

roshansingh12 commented 1 year ago

Thanks @Rodot- for letting me know. Will start working on it.

roshansingh12 commented 1 year ago

So as mentioned in the issue, should I change last_interaction_type in r_packet.py to Enum as interaction_type is enum in interaction.py ?

andrewfullard commented 1 year ago

Yes

shreyas3156 commented 1 year ago

Hi @roshansingh12, are you still working on this issue?