search

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
202 stars 404 forks source link

Abundance widget - exported csvy file issues #1797

Open luharvey opened 3 years ago

luharvey commented 3 years ago

There appears to be two issues which occur when running a simulation of a csvy file that has been created and exported by the custom abundance widget:

1.) The exported csvy file is missing a line which should read ‘tardis_model_config_version: v1.0’, this is thrown up as an error when running the exported model (I've added this line in the screenshot below). 2.) The simulation also freezes and it seems to be due to the innermost velocity in the csvy (row corresponding to the material below the photosphere) being equal to that in the shell above as changing this to a lower value makes the simulation run.

issue_screenshot

jamesgillanders commented 3 years ago

Additionally, the velocity values that are output to the csvy file do not seem to represent the v_outer values for the shells; i.e. if you generate a csvy with the outer boundary at 20000 km/s, the final row will not output v=20000, but some velocity below this. Likely a result of outputting the velocity instead of v_outer ?