CSVY Parsers Should Be Incorporated to Model Readers

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae

https://tardis-sn.github.io/tardis

201 stars 405 forks source link

CSVY Parsers Should Be Incorporated to Model Readers #1911

Open marxwillia opened 2 years ago

marxwillia commented 2 years ago

Currently, the CSVY parser functions are located with the parsers in tardis/io/parsers, but those functions belong in the tardis/io/model_reader.py file. Please move all CSVY related parser functions to the model reader file. Note that this will cause import statements to break and some tests to fail, so these things need to be fixed as well.

jayantbhakar commented 2 years ago

is this issue still open or is it resolved?

Jay-sanjay commented 11 months ago

@jayantbhakar Is the Issue resolved, I can work on it