search

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
203 stars 405 forks source link

reduce the size of photosphere in the RPacketPlotter Plot #2116

Open jayantbhakar opened 2 years ago

jayantbhakar commented 2 years ago

RPacketPlotter in PR #2119 creates a plot where every element on the plot is equally scaled. This makes the photosphere cover most of the space in the plot. We want to reduce the area covered by the photosphere in the plot.

Image

notinrange commented 1 year ago

@jayantbhakar In which amount of small scale do you want to reduce photosphere size visualization? In this visualization given to you, you want to reduce the size of a grey area right?

jayantbhakar commented 1 year ago

Yes, the grey area, starting from 0 to 10000 km/s. One idea is to make the plot start from 5000 km/s till the end, this would remove a circular area from the photosphere of radius 0 to 5000 km/s.

ishika-2110 commented 1 year ago

Hey can i work on this issue, if it's already not been assigned to someone else?

jayantbhakar commented 1 year ago

Sure, you can start by having a look at the code of RPacketPlotter, if not already. Feel free to share any doubts or ideas here.

MariamH78 commented 1 year ago

Hey! I'd like to work on this issue but I'm having a little trouble understanding the objectives and the workflow on Github is still not quite familiar to me so I have a couple of questions:

  1. Does the size of the photosphere have any physical significance? Or will any moderately-sized circle do? And if its dimensions are important, how were you planning to go about this?
  2. Should I fork your branch from that PR, work on it, then request merging there as well?
jayantbhakar commented 1 year ago

Hi @MariamH78. Glad to see your interest in this issue. To your first point, we wanted to scale down the axis starting from the origin and until the photosphere boundary. This downscaling should be seen in the axis labels as well so that the user can get an exact idea about the plot. The main idea behind the issue is that the size of the photosphere needs to be reduced as it is taking up a lot of space right now. To your second point, yes you can fork from my branch in the PR.

MariamH78 commented 1 year ago

Done! I created a pull request on your PR. Thanks for the help!

mohakmalviya commented 11 months ago

Hello sir! i would like to work on this issue if it's not been resolved yet!