tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
198 stars 403 forks source link

Switch to Ruff #2626

Closed atharva-2001 closed 1 month ago

atharva-2001 commented 3 months ago

:pencil: Description

Type: :rocket: feature :vertical_traffic_light: testing | :roller_coaster: infrastructure

This pull request fixes all fixable errors using ruff. It also makes ruff.toml consistent with astropy.

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot commented 3 months ago

*beep* *bop*

Hi, human.

The docs workflow has succeeded :heavy_check_mark:

Click here to see your results.

wkerzendorf commented 2 months ago

Let's please split this PR into small ones. The first should be all infrastructure changes that makes ruff compliant with astropy. Then we should probably go module by module.

andrewfullard commented 2 months ago

Let's please split this PR into small ones. The first should be all infrastructure changes that makes ruff compliant with astropy. Then we should probably go module by module.

Converse argument: by merging it as one PR, we can exclude a single commit from git blame.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB