search

tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
198 stars 403 forks source link

Move RPacketTracker class to a new file packet_trackers.py #2638

Closed Sumit112192 closed 2 months ago

Sumit112192 commented 2 months ago

:pencil: Description

Type: :roller_coaster: restructure This pull request is going to handle the following task

:vertical_traffic_light: Testing

How did you test these changes?

pytest tardis

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 18.75000% with 52 lines in your changes missing coverage. Please review.

Project coverage is 67.76%. Comparing base (199b03f) to head (1beb05c). Report is 4 commits behind head on master.

:exclamation: Current head 1beb05c differs from pull request most recent head fd38d0a

Please upload reports for the commit fd38d0a to get more accurate results.

Files Patch % Lines
tardis/transport/montecarlo/packet_trackers.py 14.75% 52 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2638 +/- ## ======================================= Coverage 67.76% 67.76% ======================================= Files 171 172 +1 Lines 14411 14415 +4 ======================================= + Hits 9765 9769 +4 Misses 4646 4646 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wkerzendorf commented 2 months ago

is this in a state that it should be reviewed?

wkerzendorf commented 2 months ago

This PR should only move the RPacketTracker class to packet_trackers. It also introduces a LastInteractionTracker which should be a different PR.

Sumit112192 commented 2 months ago

This PR should only move the RPacketTracker class to packet_trackers. It also introduces a LastInteractionTracker which should be a different PR.

I will do that. Thanks.

wkerzendorf commented 2 months ago

looks - good. you can now do a PR on this PR.

Sumit112192 commented 2 months ago

@wkerzendorf This PR only moves the RPacketTracker Class to a new file packet_trackers.py and is ready for review.