Closed Sumit112192 closed 2 months ago
Attention: Patch coverage is 18.75000%
with 52 lines
in your changes missing coverage. Please review.
Project coverage is 67.76%. Comparing base (
199b03f
) to head (1beb05c
). Report is 4 commits behind head on master.:exclamation: Current head 1beb05c differs from pull request most recent head fd38d0a
Please upload reports for the commit fd38d0a to get more accurate results.
Files | Patch % | Lines |
---|---|---|
tardis/transport/montecarlo/packet_trackers.py | 14.75% | 52 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
is this in a state that it should be reviewed?
This PR should only move the RPacketTracker
class to packet_trackers. It also introduces a LastInteractionTracker which should be a different PR.
This PR should only move the
RPacketTracker
class to packet_trackers. It also introduces a LastInteractionTracker which should be a different PR.
I will do that. Thanks.
looks - good. you can now do a PR on this PR.
@wkerzendorf This PR only moves the RPacketTracker Class to a new file packet_trackers.py and is ready for review.
:pencil: Description
Type: :roller_coaster:
restructure
This pull request is going to handle the following task:vertical_traffic_light: Testing
How did you test these changes?
pytest tardis
:ballot_box_with_check: Checklist
build_docs
label