tardis-sn / tardis

TARDIS - Temperature And Radiative Diffusion In Supernovae
https://tardis-sn.github.io/tardis
198 stars 403 forks source link

Refactor and add more benchmarks for montecarlo #2640

Closed officialasishkumar closed 1 month ago

officialasishkumar commented 2 months ago

:pencil: Description

Type: :rocket: feature

Refactor montecarlo Bencmarks and adding new benchmarks that cover most of the functions inside montecarlo.

:pushpin: Resources

Examples, notebooks, and links to useful references.

:vertical_traffic_light: Testing

How did you test these changes?

:ballot_box_with_check: Checklist

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

tardis-bot commented 2 months ago

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

tardis-bot commented 2 months ago

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

tardis-bot commented 2 months ago

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

tardis-bot commented 2 months ago

*beep* *bop* Hi human, I ran benchmarks as you asked comparing master (e88a31a809eb041068fffeeb16e1585b8e51f3a5) and the latest commit (a245a7d627cb7c94857620dc8bd9dda98bdad262). Here are the logs produced by ASV. Results can also be downloaded as artifacts here. Significantly changed benchmarks:

```diff · No results found ```

All benchmarks:

```diff · No results found ```
AlexHls commented 2 months ago

@officialasishkumar Can you please update the PR description, adding some details and a description of your changes?

andrewfullard commented 2 months ago

Can you provide example results from these benchmarks?

andrewfullard commented 2 months ago

Looks like you will need to deal with conflicts too.

officialasishkumar commented 2 months ago

result log: https://paste.opensuse.org/pastes/436f08c4d14a

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.67%. Comparing base (0df98ce) to head (ea6175a). Report is 8 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2640 +/- ## ========================================== + Coverage 67.80% 69.67% +1.87% ========================================== Files 177 181 +4 Lines 14534 14468 -66 ========================================== + Hits 9855 10081 +226 + Misses 4679 4387 -292 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

officialasishkumar commented 1 month ago

command: asv run refactor-benchmarks^! Output: https://paste.opensuse.org/pastes/bbf48b94a74c

the benchmarks are ran on all the functions in this PR.

officialasishkumar commented 1 month ago

Benchmark results for formal_integral functions: https://paste.opensuse.org/pastes/4983e0ca50cb